lkml.org 
[lkml]   [2011]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 01/11] ftrace/trivial: Clean up recordmcount.c to use Linux style comparisons
On 04/22/2011 10:40 AM, John Reiser wrote:
> On 04/22/2011 09:13 AM, Steven Rostedt wrote:
>> Although, I have no idea why you choose the 0 < var, that totally
>> confuses me. It does not play any role in assignments. What bug is that
>> preventing? When I want to know if a variable is greater than zero, I
>> don't show it as zero less than the var.
>
> Using ">" can be confused visually with "->", and I want to reduce those
> chances. I also prefer a style that is prefix oriented, and with constants
> on the left. I mentally combine the left constant and the infix operator
> into a special case prefix operator. This speeds my parsing because it
> reduces stack depth and enables faster scanning. This is particularly
> helpful when the constant is narrow and the other operand is wider.
>

I think you will find you're significantly in the minority when it comes
to that preference.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.



\
 
 \ /
  Last update: 2011-04-22 19:59    [W:0.053 / U:0.772 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site