Messages in this thread | | | Date | Fri, 22 Apr 2011 10:40:38 -0700 | From | John Reiser <> | Subject | Re: [RFC][PATCH 01/11] ftrace/trivial: Clean up recordmcount.c to use Linux style comparisons |
| |
On 04/22/2011 09:13 AM, Steven Rostedt wrote: > Although, I have no idea why you choose the 0 < var, that totally > confuses me. It does not play any role in assignments. What bug is that > preventing? When I want to know if a variable is greater than zero, I > don't show it as zero less than the var.
Using ">" can be confused visually with "->", and I want to reduce those chances. I also prefer a style that is prefix oriented, and with constants on the left. I mentally combine the left constant and the infix operator into a special case prefix operator. This speeds my parsing because it reduces stack depth and enables faster scanning. This is particularly helpful when the constant is narrow and the other operand is wider.
-- John Reiser
| |