Messages in this thread | | | From | "Heasley, Seth" <> | Date | Fri, 22 Apr 2011 09:47:34 -0700 | Subject | RE: [PATCH 2.6.39-rc3] i2c-i801: SMBus patch for Intel Panther Point DeviceIDs |
| |
Hi Jean,
>With each new chip, we have to add the SMBus device ID to pci_ids.h, >then wait for Jesse to merge that, and only then I can apply the >changes to i2c-i801.c. This approach slows things down needlessly. > >It isn't mandatory to add IDs to pci_ids.h when an ID is only used >locally in a device driver. So what I would like to propose is that we >move all PCI_DEVICE_ID_INTEL_*_SMBUS declarations from pci_ids.h to >i2c-i801.c now. Then you can resubmit your Panther Point patches, and >the pci and i2c parts will be independent, so Jesse and myself don't >depend on each other to apply them. > >Seth, if you agree, I can take care of the move, or you can send a >patch doing that, whatever you prefer.
I've been thinking about this one myself, and I tend to agree. It'd probably be simpler if you went ahead and made the changes, and I'll be happy to review them.
-Seth
| |