lkml.org 
[lkml]   [2011]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/7] signal: sigprocmask: narrow the scope of ->siglock
On Mon, 18 Apr 2011 15:45:38 +0200
Oleg Nesterov <oleg@redhat.com> wrote:

> No functional changes, preparation to simplify the review of the next change.
>
> 1. We can read current->block lockless, nobody else can ever change this mask.
>
> 2. Calculate the resulting sigset_t outside of ->siglock into the temporary
> variable, then take ->siglock and change ->blocked.
>
> Also, kill the stale comment about BKL.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

Thanks for that updated comment about not being able to change
->blocked from irq context!

Reviewed-by: Matt Fleming <matt.fleming@linux.intel.com>


\
 
 \ /
  Last update: 2011-04-22 14:33    [from the cache]
©2003-2011 Jasper Spaans