lkml.org 
[lkml]   [2011]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/4] davinci-mcasp: fix _CBM_CFS pin directions
    Date
    The current davinci_mcasp_set_dai_fmt() sets bits ACLKX and ACLKR in the PDIR
    register for the codec clock-master/frame-slave mode; however, this results in
    the ACLKX and ACLKR pins being outputs according to SPRUFM1 [1] which
    conflicts with "codec is clock master."

    Similarly to the previous patch in this series, "fix _CBM_CFS hw_params" --
    For codec clock-master/frame-slave mode (_CMB_CFS), clear bits ACLKX and ACLKR
    in the PDIR register to set the pins as inputs and hence allow externally
    sourced bit-clocks.

    [1] http://www.ti.com/litv/pdf/sprufm1

    Signed-off-by: Ben Gardiner <bengardiner@nanometrics.ca>
    Reviewed-by: James Nuss <jamesnuss@nanometrics.ca>
    ---
    sound/soc/davinci/davinci-mcasp.c | 4 +++-
    1 files changed, 3 insertions(+), 1 deletions(-)

    diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
    index 8004643..0a3d891 100644
    --- a/sound/soc/davinci/davinci-mcasp.c
    +++ b/sound/soc/davinci/davinci-mcasp.c
    @@ -445,8 +445,10 @@ static int davinci_mcasp_set_dai_fmt(struct snd_soc_dai *cpu_dai,
    mcasp_clr_bits(base + DAVINCI_MCASP_ACLKRCTL_REG, ACLKRE);
    mcasp_set_bits(base + DAVINCI_MCASP_RXFMCTL_REG, AFSRE);

    + mcasp_clr_bits(base + DAVINCI_MCASP_PDIR_REG,
    + ACLKX | ACLKR);
    mcasp_set_bits(base + DAVINCI_MCASP_PDIR_REG,
    - ACLKX | AFSX | ACLKR | AFSR);
    + AFSX | AFSR);
    break;
    case SND_SOC_DAIFMT_CBM_CFM:
    /* codec is clock and frame master */
    --
    1.7.1


    \
     
     \ /
      Last update: 2011-04-21 20:21    [W:0.021 / U:0.684 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site