lkml.org 
[lkml]   [2011]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v3] mm: make expand_downwards symmetrical to expand_upwards
Date
> diff --git a/arch/parisc/mm/init.c b/arch/parisc/mm/init.c
> --- a/arch/parisc/mm/init.c
> +++ b/arch/parisc/mm/init.c
> @@ -266,8 +266,10 @@ static void __init setup_bootmem(void)
> }
> memset(pfnnid_map, 0xff, sizeof(pfnnid_map));
>
> - for (i = 0; i < npmem_ranges; i++)
> + for (i = 0; i < npmem_ranges; i++) {
> + node_set_state(i, N_NORMAL_MEMORY);
> node_set_online(i);
> + }
> #endif


I'm surprised this one. If arch code doesn't initialized N_NORMAL_MEMORY,
(or N_HIGH_MEMORY. N_HIGH_MEMORY == N_NORMAL_MEMORY if CONFIG_HIGHMEM=n)
kswapd is created only at node0. wow.

The initialization must be necessary even if !NUMA, I think. ;-)
Probably we should have revisit all arch code when commit 9422ffba4a
(Memoryless nodes: No need for kswapd) was introduced, at least.

Thank you David. and I'm sad this multi level unforunate mismatch....



\
 
 \ /
  Last update: 2011-04-21 15:05    [W:0.214 / U:0.456 seconds]
©2003-2014 Jasper Spaans. Advertise on this site