Messages in this thread | | | Date | Wed, 20 Apr 2011 09:42:48 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH v2] driver core: let dev_set_drvdata return int instead of void as it can fail |
| |
On Tue, Apr 19, 2011 at 04:58:12PM -0700, Greg KH wrote: > On Mon, Apr 11, 2011 at 08:42:58PM +0200, Uwe Kleine-König wrote: > > Before commit > > > > b402843 (Driver core: move dev_get/set_drvdata to drivers/base/dd.c) > > > > calling dev_set_drvdata with dev=NULL was an unchecked error. After some > > discussion about what to return in this case removing the check (and so > > producing a null pointer exception) seems fine. > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > --- > > Hello, > > > > @Viresh: as I didn't choose to return -EINVAL I didn't add your Reviewed-by: > > I'm confused by this thread, care to resend all of these in a series > against the latest linux-next tree? No problem, here it comes. This are patches 1 to 4 of the original series + v2 of patch 5 (that didn't have 5/5 in the subject).
Best regards, Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |