Messages in this thread Patch in this message | | | From | Jan Kara <> | Subject | [PATCH] vfs: Pass setxattr(2) flags properly | Date | Wed, 20 Apr 2011 20:30:40 +0200 |
| |
For some reason generic_setxattr() did not pass flags (XATTR_CREATE, XATTR_REPLACE) to the filesystem specific helper. This caused that setxattr(2) syscall just ignored these flags.
Fix the bug by passing flags correctly.
Signed-off-by: Jan Kara <jack@suse.cz> --- fs/xattr.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Who's handling VFS changes when Al is away? Andrew?
diff --git a/fs/xattr.c b/fs/xattr.c index a19acdb..f1ef949 100644 --- a/fs/xattr.c +++ b/fs/xattr.c @@ -666,7 +666,7 @@ generic_setxattr(struct dentry *dentry, const char *name, const void *value, siz handler = xattr_resolve_name(dentry->d_sb->s_xattr, &name); if (!handler) return -EOPNOTSUPP; - return handler->set(dentry, name, value, size, 0, handler->flags); + return handler->set(dentry, name, value, size, flags, handler->flags); } /* -- 1.7.1
| |