lkml.org 
[lkml]   [2011]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH followup] mm: get rid of CONFIG_STACK_GROWSUP || CONFIG_IA64
    Date
    > Hi Kosaki,
    >
    > On Wed 20-04-11 09:33:26, KOSAKI Motohiro wrote:
    > > > While I am in the cleanup mode. We should use VM_GROWSUP rather than
    > > > tricky CONFIG_STACK_GROWSUP||CONFIG_IA64.
    > > >
    > > > What do you think?
    > >
    > > Now, VM_GROWSUP share the same value with VM_NOHUGEPAGE.
    > > (this trick use the fact that thp don't support any stack growup architecture)
    >
    > I am not sure I understand you. AFAICS, VM_GROWSUP is defined to non 0
    > only if CONFIG_STACK_GROWSUP||CONFIG_IA64 (include/linux/mm.h).
    > And we use it to determine whether expand_stack_growsup[*] should be
    > defined (in include/linux/mm.h).
    >
    > The patch basically unifies the way how we export expand_stack_growsup
    > function and how define it (in mm/mmap.c).
    >
    > So either we should use CONFIG_STACK_GROWSUP||CONFIG_IA64 at both places
    > or we should use VM_GROWSUP trick. I am for the later one.
    >
    > Am I missing something?
    >
    > ---
    > [*] the previous patch renamed expand_growsup to expand_stack_growsup.

    Right you are. sorry.





    \
     
     \ /
      Last update: 2011-04-20 09:11    [W:3.445 / U:0.680 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site