lkml.org 
[lkml]   [2011]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] tmpfs: implement generic xattr support
    From
    On Tue, Apr 19, 2011 at 9:04 PM, Miklos Szeredi <miklos@szeredi.hu> wrote:

    > +static ssize_t shmem_listxattr(struct dentry *dentry, char *buffer, size_t size)

    > +       spin_lock(&dentry->d_inode->i_lock);
    > +       list_for_each_entry(xattr, &info->xattr_list, list) {
    > +               /* skip "trusted." attributes for unprivileged callers */
    > +               if (!trusted && xattr_is_trusted(xattr->name))
    > +                       continue;
    > +
    > +               used += strlen(xattr->name) + 1;
    > +               if (buffer) {
    > +                       if (size < used) {
    > +                               used = -ERANGE;
    > +                               break;
    > +                       }
    > +                       strncpy(buffer, xattr->name, strlen(xattr->name) + 1);
    >+ buffer += strlen(xattr->name) + 1;

    Why are you doing a strncpy here? strcpy() isn't going to copy more
    than strlen(xattr->name) + 1 bytes, and you know buffer is large
    enough to hold that because of the previous if (size < used) check?

    If you assigned the first strlen(xattr->name) + 1 to a temporary
    variable, you could use memcpy here, and avoid the 3 repeated
    strlen(xattr->name) calls.

    Phillip
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-04-20 04:21    [W:0.022 / U:30.892 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site