lkml.org 
[lkml]   [2011]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] n_tracerouter and n_tracesink ldisc additions.
On Tue, 19 Apr 2011 17:05:55 -0700 J Freyensee wrote:

> On Tue, 2011-04-19 at 16:20 -0700, Randy Dunlap wrote:
> > On Tue, 19 Apr 2011 15:58:09 -0700 james_p_freyensee@linux.intel.com wrote:
> >
> > > drivers/tty/Kconfig | 31 ++++++
> > > drivers/tty/Makefile | 2 +
> > > drivers/tty/n_tracerouter.c | 241 ++++++++++++++++++++++++++++++++++++++++++
> > > drivers/tty/n_tracesink.c | 244 +++++++++++++++++++++++++++++++++++++++++++
> > > drivers/tty/n_tracesink.h | 36 +++++++
> > > include/linux/tty.h | 2 +
> > > 6 files changed, 556 insertions(+), 0 deletions(-)
> > > create mode 100644 drivers/tty/n_tracerouter.c
> > > create mode 100644 drivers/tty/n_tracesink.c
> > > create mode 100644 drivers/tty/n_tracesink.h
> > >
> > > diff --git a/drivers/tty/Kconfig b/drivers/tty/Kconfig
> > > index 3fd7199..d1ab9c0 100644
> > > --- a/drivers/tty/Kconfig
> > > +++ b/drivers/tty/Kconfig
> > > @@ -319,3 +319,34 @@ config N_GSM
> > > This line discipline provides support for the GSM MUX protocol and
> > > presents the mux as a set of 61 individual tty devices.
> > >
> > > +config TRACE_ROUTER
> > > + tristate "Trace data router for MIPI P1149.7 cJTAG standard"
> > > + depends on TRACE_SINK
> > > + default Y
> >
> > Don't add default Y misc drivers.
>
> This actually isn't a misc driver. From the help, it's "Linux tty line
> discipline"
>
> But I can turn it off.

OK, random drivers. Thanks.


> > > +/* Other ldisc drivers use 65536 which basically means,
> > > + * 'I can always accept 64k' and flow control is off.
> > > + * This number is deemed appropriate for this driver.
> > > + */
> >
> > Fix multi-line comment style throughout.
>
> Could you please show me how and what you are looking for? You pointed
> out a similar issue using a different comment style, despite that at
> least I made it a point to maintain a consistent comment style
> throughout the code in the file. So I'm not quite sure what is desired.
> Thanks, I appreciate this.

See Documentation/CodingStyle, section 8:

The preferred style for long (multi-line) comments is:

/*
* This is the preferred style for multi-line
* comments in the Linux kernel source code.
* Please use it consistently.
*
* Description: A column of asterisks on the left side,
* with beginning and ending almost-blank lines.
*/

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***


\
 
 \ /
  Last update: 2011-04-20 02:17    [W:2.244 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site