lkml.org 
[lkml]   [2011]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2] driver core: let dev_set_drvdata return int instead of void as it can fail
    On Mon, Apr 11, 2011 at 08:42:58PM +0200, Uwe Kleine-König wrote:
    > Before commit
    >
    > b402843 (Driver core: move dev_get/set_drvdata to drivers/base/dd.c)
    >
    > calling dev_set_drvdata with dev=NULL was an unchecked error. After some
    > discussion about what to return in this case removing the check (and so
    > producing a null pointer exception) seems fine.
    >
    > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    > ---
    > Hello,
    >
    > @Viresh: as I didn't choose to return -EINVAL I didn't add your Reviewed-by:

    I'm confused by this thread, care to resend all of these in a series
    against the latest linux-next tree?

    thanks,

    greg k-h
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-04-20 02:03    [W:0.020 / U:0.608 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site