lkml.org 
[lkml]   [2011]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] break out page allocation warning code
On Tue, 19 Apr 2011, KOSAKI Motohiro wrote:

> The rule is,
>
> 1) writing comm
> need task_lock
> 2) read _another_ thread's comm
> need task_lock
> 3) read own comm
> no need task_lock
>

That was true a while ago, but you now need to protect every thread's
->comm with get_task_comm() or ensuring task_lock() is held to protect
against /proc/pid/comm which can change other thread's ->comm. That was
different before when prctl(PR_SET_NAME) would only operate on current, so
no lock was needed when reading current->comm.


\
 
 \ /
  Last update: 2011-04-19 23:25    [W:0.113 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site