lkml.org 
[lkml]   [2011]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[07/26] [IA64] mca.c: Fix cast from integer to pointer warning
    2.6.33-longterm review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Jeff Mahoney <jeffm@suse.com>

    commit c1d036c4d1cb00b7e8473a2ad0a78f13e13a8183 upstream.

    ia64_mca_cpu_init has a void *data local variable that is assigned
    the value from either __get_free_pages() or mca_bootmem(). The problem
    is that __get_free_pages returns an unsigned long and mca_bootmem, via
    alloc_bootmem(), returns a void *. format_mca_init_stack takes the void *,
    and it's also used with __pa(), but that casts it to long anyway.

    This results in the following build warning:

    arch/ia64/kernel/mca.c:1898: warning: assignment makes pointer from
    integer without a cast

    Cast the return of __get_free_pages to a void * to avoid
    the warning.

    Signed-off-by: Jeff Mahoney <jeffm@suse.com>
    Signed-off-by: Tony Luck <tony.luck@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    arch/ia64/kernel/mca.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/arch/ia64/kernel/mca.c
    +++ b/arch/ia64/kernel/mca.c
    @@ -1858,7 +1858,8 @@ ia64_mca_cpu_init(void *cpu_data)
    data = mca_bootmem();
    first_time = 0;
    } else
    - data = __get_free_pages(GFP_KERNEL, get_order(sz));
    + data = (void *)__get_free_pages(GFP_KERNEL,
    + get_order(sz));
    if (!data)
    panic("Could not allocate MCA memory for cpu %d\n",
    cpu);



    \
     
     \ /
      Last update: 2011-04-19 23:11    [W:0.020 / U:31.092 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site