lkml.org 
[lkml]   [2011]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[18/70] bridge: Fix possibly wrong MLD queries ethernet source address
    2.6.38-stable review patch.  If anyone has any objections, please let us know.

    ------------------


    From: Linus Lüssing <linus.luessing@web.de>

    [ Upstream commit a7bff75b087e7a355838a32efe61707cfa73c194 ]

    The ipv6_dev_get_saddr() is currently called with an uninitialized
    destination address. Although in tests it usually seemed to nevertheless
    always fetch the right source address, there seems to be a possible race
    condition.

    Therefore this commit changes this, first setting the destination
    address and only after that fetching the source address.

    Reported-by: Jan Beulich <JBeulich@novell.com>
    Signed-off-by: Linus Lüssing <linus.luessing@web.de>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    ---
    net/bridge/br_multicast.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/bridge/br_multicast.c
    +++ b/net/bridge/br_multicast.c
    @@ -445,9 +445,9 @@ static struct sk_buff *br_ip6_multicast_
    ip6h->payload_len = htons(8 + sizeof(*mldq));
    ip6h->nexthdr = IPPROTO_HOPOPTS;
    ip6h->hop_limit = 1;
    + ipv6_addr_set(&ip6h->daddr, htonl(0xff020000), 0, 0, htonl(1));
    ipv6_dev_get_saddr(dev_net(br->dev), br->dev, &ip6h->daddr, 0,
    &ip6h->saddr);
    - ipv6_addr_set(&ip6h->daddr, htonl(0xff020000), 0, 0, htonl(1));
    ipv6_eth_mc_map(&ip6h->daddr, eth->h_dest);

    hopopt = (u8 *)(ip6h + 1);

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-04-19 22:31    [W:0.022 / U:0.940 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site