lkml.org 
[lkml]   [2011]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 14/20] mm: Remove i_mmap_lock lockbreak
    On Fri, 01 Apr 2011 14:13:12 +0200
    Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:

    > Hugh says:
    > "The only significant loser, I think, would be page reclaim (when
    > concurrent with truncation): could spin for a long time waiting for
    > the i_mmap_mutex it expects would soon be dropped? "
    >
    > Counter points:
    > - cpu contention makes the spin stop (need_resched())
    > - zap pages should be freeing pages at a higher rate than reclaim
    > ever can
    >
    > I think the simplification of the truncate code is definately worth it.

    Well, we don't need to guess. These things are testable!


    \
     
     \ /
      Last update: 2011-04-19 22:11    [W:0.027 / U:0.136 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site