Messages in this thread | | | Date | Tue, 19 Apr 2011 19:01:21 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH v4 1/2] apic: Fix error interrupt report at all APs |
| |
* Youquan Song <youquan.song@intel.com> wrote:
> Recently, customer report that once machine boot, there are many error interrupt > reported with exact number of all APs. > > The root cause is Local APIC will generate error interrupt when it detect > the illegal vector (one in 0 ~ 15) in an interrupt message received or > interrupt generate from local vector table or self IPI. SDM3A.chapter 10. > > AP LAPIC thermal sensor register will be reset to 0x10000, if thermal throttling > interrupt take over by BIOS, it need restore AP with the thermal sensor register > value of geting from BSP, otherwise cause system issue. If BIOS does not take > over the thermal interrupt, The restore value will be CPU rest value of 0x10000, > which means the interrupt vector is zero. After writing 0x10000 to thermal > sensor LVT, the processor will recieve the error interrupt report if the APIC > error interrupt is also set. > > This patch add check the BIOS whether take over the thermal interrupt by look > at interrupt delivery mode not fixed mode(BIOS handle will be SMI mode) before > restore AP's thermal LVT. So the agony noise of error interrupt will dismiss > when boot on machine that BIOS does not handle thermal interrupt.. > > > Signed-off-by: Youquan Song <youquan.song@intel.com> > Acked-by: Suresh Siddha <suresh.b.siddha@intel.com> > Acked-by: Yong Wang <yong.y.wang@intel.com> > --- > arch/x86/include/asm/apicdef.h | 1 + > arch/x86/kernel/cpu/mcheck/therm_throt.c | 12 +++++++----- > 2 files changed, 8 insertions(+), 5 deletions(-)
I don't disagree with this change, but unfortunately the changelog is in absolutely unreadable English. Please fix it or find someone who can fix it for you.
I decoded and fixed the changelog of the 2/2 patch of your series so no need to do it for that patch.
Thanks,
Ingo
| |