Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH 4/4] module: Use the binary search for symbols resolution | Date | Tue, 19 Apr 2011 21:05:49 +0930 |
| |
On Tue, 19 Apr 2011 09:44:20 +0800, Wanlong Gao <wanlong.gao@gmail.com> wrote: > 2011-4-19 9:37, Rusty Russell wroted: > > On Sat, 16 Apr 2011 22:32:08 +0800, Wanlong Gao<wanlong.gao@gmail.com> wrote: > >>> + sym = bsearch(fsa->name, syms->start, syms->stop - syms->start, > >> As the bsearch func, why not change the syms->stop to syms->end ? > >> Hmm..Just a stupid suggestion. > > > > > > The names are derived from the linker symbols for end of sections, which > > is __stop_<sectionname>. > > > > Cheers, > > Rusty. > As this , why not change the bsearch's "end" to "stop", too ? It will be > more readable.
I'm confused. bsearch uses a count, not an end pointer...
Rusty.
| |