Messages in this thread | | | Date | Mon, 18 Apr 2011 16:39:28 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH 2/3] x86, cpu: Clean up and unify the NOP selection infrastructure |
| |
On 04/18/2011 04:31 PM, Steven Rostedt wrote: > > Can we please add a comment to this. The original (above) was confusing > enough, but at least it used asm() so it wasn't that bad to figure out. > Or at least the asm() usage would trigger in one's mind to think "Damn! > They chose to use 'asm', it must be some kind of nasty trick. Let's take > a better look at WTF they are doing!". > > Now the use a normal character array actual makes this even more subtle.
OK... I never thought it was particularly subtle, but okay.
A much bigger issue with this particular patch is that the __init{data,const}_or_module presumably needs to be removed from these structures, right?
-hpa
| |