lkml.org 
[lkml]   [2011]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V14 3/4] ptp: Added a clock driver for the IXP46x.
On Mon, Apr 18, 2011 at 08:56:03AM +0200, Arnd Bergmann wrote:
> On Monday 18 April 2011, Richard Cochran wrote:
> > +
> > + lo = __raw_readl(&regs->channel[ch].src_uuid_lo);
> > + hi = __raw_readl(&regs->channel[ch].src_uuid_hi);
> > +
>
> I guess you should use readl(), not __raw_readl() here. The __raw_* functions
> are not meant for device drivers.

Krzysztof had a different opinion about this.

https://lkml.org/lkml/2011/1/8/67

Anyway, it is his driver, and I just followed what he does elsewhere
in the driver. It make sense to me to keep the driver consistent.
Maybe we should make the change throughout?

Thanks,
Richard


\
 
 \ /
  Last update: 2011-04-18 10:09    [W:0.059 / U:0.592 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site