lkml.org 
[lkml]   [2011]   [Apr]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH -next] hid-example: fix some build issues
From: Randy Dunlap <randy.dunlap@oracle.com>

samples/hid-example.o needs some Kconfig and Makefile additions
in order to build. It should use <linux/*.h> headers from
the build tree, so use HEADERS_CHECK to require that those
header files be present.
Change the kconfig symbol from tristate to bool since
userspace cannot be built as loadable modules.

However, I don't understand why the userspace header files are
not present as reported in Andrew's build log, since it builds
OK on x86_64 without any of these changes.

Reported-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Alan Ott <alan@signal11.us>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: linux-input@vger.kernel.org
---
samples/Kconfig | 4 ++--
samples/hidraw/Makefile | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
--- linux-next-20110418.orig/samples/hidraw/Makefile
+++ linux-next-20110418/samples/hidraw/Makefile
@@ -6,3 +6,5 @@ hostprogs-y := hid-example

# Tell kbuild to always build the programs
always := $(hostprogs-y)
+
+HOSTCFLAGS_hid-example.o += -I$(objtree)/usr/include
--- linux-next-20110418.orig/samples/Kconfig
+++ linux-next-20110418/samples/Kconfig
@@ -62,8 +62,8 @@ config SAMPLE_KDB
command to the kdb shell.

config SAMPLE_HIDRAW
- tristate "Build simple hidraw example"
- depends on HIDRAW
+ bool "Build simple hidraw example"
+ depends on HIDRAW && HEADERS_CHECK
help
Build an example of how to use hidraw from userspace.


\
 
 \ /
  Last update: 2011-04-18 20:15    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site