Messages in this thread | | | Date | Mon, 18 Apr 2011 15:30:45 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 14/14] regulator: 88pm8607: avoid to use constraint name in driver |
| |
On Mon, Apr 18, 2011 at 10:04:11PM +0800, Haojian Zhuang wrote: > Avoid to use constraint name in driver. So use driver_data instead to > store regulator name in platform driver.
If this is something that's present in the current driver it should be fixed for 2.6.39 so should be a patch at the start of the series which can be applied separately to the others.
> + /* pdata->driver_data stores the name of regulator */ > + if (!strcmp(info->desc.name, pdata->driver_data)) > break;
Why not just use #defines in the header? It'd be less error prone if nothing else.
| |