Messages in this thread | | | From | Haojian Zhuang <> | Date | Mon, 18 Apr 2011 06:49:44 -0700 | Subject | RE: [PATCH 12/13] regulator: check name in initialization of max8925 |
| |
>-----Original Message----- >From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com] >Sent: 2011年4月17日 2:02 AM >To: Haojian Zhuang >Cc: sameo@linux.intel.com; haojian.zhuang@gmail.com; linux- >kernel@vger.kernel.org; Liam Girdwood >Subject: Re: [PATCH 12/13] regulator: check name in initialization of >max8925 > >On Wed, Apr 13, 2011 at 10:51:03PM +0800, Haojian Zhuang wrote: >> Check name in initialization of max8925 regulator driver. > >> + if (!strcmp(ri->desc.name, pdata->constraints.name)) >> + break; > >This isn't a good change - the whole point of the name in the >constraints is that it allows the user to assign an arbatrary string >which is useful for the board. The driver should never be looking >inside the constraints at all, the core will apply the constraints for >you.
I'll move the name of regulator into regulator_init_data->driver_data.
Thanks Haojian
| |