lkml.org 
[lkml]   [2011]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4/4] perf, x86: Fix event scheduler to solve complex scheduling problems
From
Date
On Sat, 2011-04-16 at 12:14 +0200, Ingo Molnar wrote:
> * Peter Zijlstra <peterz@infradead.org> wrote:
>
> > On Sat, 2011-04-16 at 11:43 +0200, Ingo Molnar wrote:
> > > I'd also prefer if we first had actual testcases in 'perf test' for all these
> > > failures - it took an *awfully* long time to find these regressions (the event
> > > scheduler code has been committed for months), while with proper testcases it
> > > would only take a second to run 'perf test'.
> >
> > These cases only exist on AMD F15, I don't think there's many people
> > with such systems around.
>
> Well, if the trend continues we'll have more twisted constraints and more bugs
> of this sort, so having a testsuite sure cannot hurt, right?

For sure. But the problem with writing test cases at the perf userspace
level is that they're very hardware specific. It would be much easier to
write unit tests for the solver itself.


\
 
 \ /
  Last update: 2011-04-16 12:19    [W:0.085 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site