Messages in this thread Patch in this message | | | Date | Sat, 16 Apr 2011 14:13:13 +0530 | From | Raghavendra D Prabhu <> | Subject | [PATCH 1/2] FIX: engine_state is uninitialized |
| |
In case lp5521_read() returns EIO, engine_state is in an uninitialized state. This adds checks to fix that.
Signed-off-by: Raghavendra D Prabhu <rprabhu@wnohang.net> --- drivers/leds/leds-lp5521.c | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/leds/leds-lp5521.c b/drivers/leds/leds-lp5521.c index c0cff64..6c5eac0 100644 --- a/drivers/leds/leds-lp5521.c +++ b/drivers/leds/leds-lp5521.c @@ -176,11 +176,13 @@ static int lp5521_set_engine_mode(struct lp5521_engine *engine, u8 mode) ret = lp5521_read(client, LP5521_REG_OP_MODE, &engine_state); + if (ret == 0){ /* set mode only for this engine */ - engine_state &= ~(engine->engine_mask); - mode &= engine->engine_mask; - engine_state |= mode; - ret |= lp5521_write(client, LP5521_REG_OP_MODE, engine_state); + engine_state &= ~(engine->engine_mask); + mode &= engine->engine_mask; + engine_state |= mode; + ret |= lp5521_write(client, LP5521_REG_OP_MODE, engine_state); + } return ret; } -- 1.7.4.4 -------------------------- Raghavendra Prabhu GPG Id : D72BE977 Fingerprint: B93F EBCB 8E05 7039 CD3C A4B8 A616 DCA1 D72B E977
| |