lkml.org 
[lkml]   [2011]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 12/13] regulator: check name in initialization of max8925
On Wed, Apr 13, 2011 at 10:51:03PM +0800, Haojian Zhuang wrote:
> Check name in initialization of max8925 regulator driver.

> + if (!strcmp(ri->desc.name, pdata->constraints.name))
> + break;

This isn't a good change - the whole point of the name in the
constraints is that it allows the user to assign an arbatrary string
which is useful for the board. The driver should never be looking
inside the constraints at all, the core will apply the constraints for
you.


\
 
 \ /
  Last update: 2011-04-16 20:03    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site