Messages in this thread | | | Date | Fri, 15 Apr 2011 15:53:47 -0700 (PDT) | From | Dan Magenheimer <> | Subject | RE: [PATCH] xen: cleancache shim to Xen Transcendent Memory |
| |
> From: Ian Campbell [mailto:Ian.Campbell@citrix.com] > Sent: Friday, April 15, 2011 4:02 PM > Subject: Re: [PATCH] xen: cleancache shim to Xen Transcendent Memory > > On Thu, 2011-04-14 at 14:20 -0700, Dan Magenheimer wrote: > > [PATCH] xen: cleancache shim to Xen Transcendent Memory > > > > This patch provides a shim between the kernel-internal cleancache > > API (see Documentation/mm/cleancache.txt) and the Xen Transcendent > > Memory ABI (see http://oss.oracle.com/projects/tmem). > > There's no need to build this into a kernel which doesn't have > cleancache (or one of the other frontends), is there? I think there > should be a Kconfig option (even if its not a user visible one) with > the appropriate depends/selects.
Yes, you're right. It should eventually depend on
CONFIG_CLEANCACHE || CONFIG_FRONTSWAP
though there's no sense merging this xen cleancache shim at all unless/until Linus merges cleancache (and hopefully later some evolution of frontswap).
And once cleancache (and/or frontswap) is merged, there's very little reason NOT to enable one or both on a Xen guest kernel.
Thanks, Dan
| |