lkml.org 
[lkml]   [2011]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[34-longterm 145/209] driver/net/benet: fix be_cmd_multicast_set() memcpy bug
    Date
    From: Joe Jin <joe.jin@oracle.com>

    =====================================================================
    | This is a commit scheduled for the next v2.6.34 longterm release. |
    | If you see a problem with using this for longterm, please comment.|
    =====================================================================

    commit 408cc293c29ada769ae772420a39961320da1854 upstream

    Regarding benet be_cmd_multicast_set() function, now using
    netdev_for_each_mc_addr() helper for mac address copy, but
    when copying to req->mac[] did not increase of the index.

    Cc: Sathya Perla <sathyap@serverengines.com>
    Cc: Subbu Seetharaman <subbus@serverengines.com>
    Cc: Sarveshwar Bandi <sarveshwarb@serverengines.com>
    Cc: Ajit Khaparde <ajitk@serverengines.com>
    Signed-off-by: Joe Jin <joe.jin@oracle.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    ---
    drivers/net/benet/be_cmds.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/net/benet/be_cmds.c b/drivers/net/benet/be_cmds.c
    index d0ef4ac..e0578d1 100644
    --- a/drivers/net/benet/be_cmds.c
    +++ b/drivers/net/benet/be_cmds.c
    @@ -1163,7 +1163,7 @@ int be_cmd_multicast_set(struct be_adapter *adapter, u32 if_id,

    i = 0;
    netdev_for_each_mc_addr(mc, netdev)
    - memcpy(req->mac[i].byte, mc->dmi_addr, ETH_ALEN);
    + memcpy(req->mac[i++].byte, mc->dmi_addr, ETH_ALEN);
    } else {
    req->promiscuous = 1;
    }
    --
    1.7.4.4


    \
     
     \ /
      Last update: 2011-04-14 20:19    [W:4.197 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site