Messages in this thread | | | Date | Thu, 14 Apr 2011 20:09:36 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 1/5] asm-generic/ptrace.h: start a common low level ptrace helper |
| |
On 04/14, Mike Frysinger wrote: > > This implements a bunch of helper funcs for poking the registers of a > ptrace structure. Now common code should be able to portably update > specific registers (like kgdb updating the PC).
The whole series looks correct, but I am a bit confused...
> +#ifndef GET_IP > +#define GET_IP(regs) ((regs)->pc) > +#endif
Could you explain this ifndef ?
IIUC, this should be included by arch/*/asm/ptrace.h. Isn't it better to simply require that if you include asm-generic/ptrace.h you should provide the necessary GET_* macros?
(regs)->pc looks a bit strange in asm-generic. But please feel free to ignore.
Oleg.
| |