lkml.org 
[lkml]   [2011]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[34-longterm 197/209] av7110: check for negative array offset
    Date
    From: Dan Carpenter <error27@gmail.com>

    =====================================================================
    | This is a commit scheduled for the next v2.6.34 longterm release. |
    | If you see a problem with using this for longterm, please comment.|
    =====================================================================

    commit cb26a24ee9706473f31d34cc259f4dcf45cd0644 upstream

    info->num comes from the user. It's type int. If the user passes
    in a negative value that would cause memory corruption.

    Signed-off-by: Dan Carpenter <error27@gmail.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    ---
    drivers/media/dvb/ttpci/av7110_ca.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/media/dvb/ttpci/av7110_ca.c b/drivers/media/dvb/ttpci/av7110_ca.c
    index ac7779c..d884aac 100644
    --- a/drivers/media/dvb/ttpci/av7110_ca.c
    +++ b/drivers/media/dvb/ttpci/av7110_ca.c
    @@ -278,7 +278,7 @@ static int dvb_ca_ioctl(struct inode *inode, struct file *file,
    {
    ca_slot_info_t *info=(ca_slot_info_t *)parg;

    - if (info->num > 1)
    + if (info->num < 0 || info->num > 1)
    return -EINVAL;
    av7110->ci_slot[info->num].num = info->num;
    av7110->ci_slot[info->num].type = FW_CI_LL_SUPPORT(av7110->arm_app) ?
    --
    1.7.4.4


    \
     
     \ /
      Last update: 2011-04-14 20:05    [W:0.027 / U:0.016 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site