| From | Paul Gortmaker <> | Subject | [34-longterm 203/209] sunrpc/cache: fix module refcnt leak in a failure path | Date | Thu, 14 Apr 2011 13:56:01 -0400 |
| |
From: Li Zefan <lizf@cn.fujitsu.com>
===================================================================== | This is a commit scheduled for the next v2.6.34 longterm release. | | If you see a problem with using this for longterm, please comment.| =====================================================================
commit a5990ea1254cd186b38744507aeec3136a0c1c95 upstream
Don't forget to release the module refcnt if seq_open() returns failure.
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com> Cc: J. Bruce Fields <bfields@fieldses.org> Cc: Neil Brown <neilb@suse.de> Cc: Trond Myklebust <Trond.Myklebust@netapp.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> --- net/sunrpc/cache.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c index 39bddba..b7af6b2 100644 --- a/net/sunrpc/cache.c +++ b/net/sunrpc/cache.c @@ -1233,8 +1233,10 @@ static int content_open(struct inode *inode, struct file *file, if (!cd || !try_module_get(cd->owner)) return -EACCES; han = __seq_open_private(file, &cache_content_op, sizeof(*han)); - if (han == NULL) + if (han == NULL) { + module_put(cd->owner); return -ENOMEM; + } han->cd = cd; return 0; -- 1.7.4.4
|