lkml.org 
[lkml]   [2011]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[34-longterm 079/209] USB: storage: sierra_ms: fix sysfs file attribute
    Date
    From: Greg Kroah-Hartman <gregkh@suse.de>

    =====================================================================
    | This is a commit scheduled for the next v2.6.34 longterm release. |
    | If you see a problem with using this for longterm, please comment.|
    =====================================================================

    commit d9624e75f6ad94d8a0718c1fafa89186d271a78c upstream.

    A non-writable sysfs file shouldn't have writable attributes.

    Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Kevin Lloyd <klloyd@sierrawireless.com>
    Cc: Matthew Dharm <mdharm-usb@one-eyed-alien.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    ---
    drivers/usb/storage/sierra_ms.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/usb/storage/sierra_ms.c b/drivers/usb/storage/sierra_ms.c
    index 57fc2f5..ceba512 100644
    --- a/drivers/usb/storage/sierra_ms.c
    +++ b/drivers/usb/storage/sierra_ms.c
    @@ -121,7 +121,7 @@ static ssize_t show_truinst(struct device *dev, struct device_attribute *attr,
    }
    return result;
    }
    -static DEVICE_ATTR(truinst, S_IWUGO | S_IRUGO, show_truinst, NULL);
    +static DEVICE_ATTR(truinst, S_IRUGO, show_truinst, NULL);

    int sierra_ms_init(struct us_data *us)
    {
    --
    1.7.4.4


    \
     
     \ /
      Last update: 2011-04-14 19:57    [W:4.021 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site