Messages in this thread Patch in this message | | | From | Michal Nazarewicz <> | Subject | [PATCH] usb: gadget: storage_common: use kstrto*() [bug fix] | Date | Thu, 14 Apr 2011 11:55:43 +0200 |
| |
This commit fixes an embarrassing bug in the "storage_common: use kstrto*()" patch which caused fsg_store_ro() to return zero instead of the length of the consumed buffer.
Signed-off-by: Michal Nazarewicz <mina86@mina86.com> --- drivers/usb/gadget/storage_common.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
On Thu, 14 Apr 2011 04:16:35 +0200, Greg KH <gregkh@suse.de> wrote: > Ugh, I applied the first one already :(
Yes, I hoped you could quickly replace the patch without anyone noticing.
> Care to send a follow-on patch that fixes this properly?
Natuarry.
diff --git a/drivers/usb/gadget/storage_common.c b/drivers/usb/gadget/storage_common.c index 109635a..1fa4f70 100644 --- a/drivers/usb/gadget/storage_common.c +++ b/drivers/usb/gadget/storage_common.c @@ -708,7 +708,7 @@ static ssize_t fsg_show_file(struct device *dev, struct device_attribute *attr, static ssize_t fsg_store_ro(struct device *dev, struct device_attribute *attr, const char *buf, size_t count) { - ssize_t rc = count; + ssize_t rc; struct fsg_lun *curlun = fsg_lun_from_dev(dev); struct rw_semaphore *filesem = dev_get_drvdata(dev); unsigned ro; @@ -729,6 +729,7 @@ static ssize_t fsg_store_ro(struct device *dev, struct device_attribute *attr, curlun->ro = ro; curlun->initially_ro = ro; LDBG(curlun, "read-only status set to %d\n", curlun->ro); + rc = count; } up_read(filesem); return rc; -- 1.7.3.1
| |