lkml.org 
[lkml]   [2011]   [Apr]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[45/71] mfd: ab3100: world-writable debugfs *_priv files
    2.6.33-longterm review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Vasiliy Kulikov <segoon@openwall.com>

    commit f8a0697722d12a201588225999cfc8bfcbc82781 upstream.

    Don't allow everybody to change device hardware registers.

    Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
    Acked-by: Linus Walleij <linus.walleij@stericsson.com>
    Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/mfd/ab3100-core.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/mfd/ab3100-core.c
    +++ b/drivers/mfd/ab3100-core.c
    @@ -591,7 +591,7 @@ static void ab3100_setup_debugfs(struct
    ab3100_get_priv.ab3100 = ab3100;
    ab3100_get_priv.mode = false;
    ab3100_get_reg_file = debugfs_create_file("get_reg",
    - S_IWUGO, ab3100_dir, &ab3100_get_priv,
    + S_IWUSR, ab3100_dir, &ab3100_get_priv,
    &ab3100_get_set_reg_fops);
    if (!ab3100_get_reg_file) {
    err = -ENOMEM;
    @@ -601,7 +601,7 @@ static void ab3100_setup_debugfs(struct
    ab3100_set_priv.ab3100 = ab3100;
    ab3100_set_priv.mode = true;
    ab3100_set_reg_file = debugfs_create_file("set_reg",
    - S_IWUGO, ab3100_dir, &ab3100_set_priv,
    + S_IWUSR, ab3100_dir, &ab3100_set_priv,
    &ab3100_get_set_reg_fops);
    if (!ab3100_set_reg_file) {
    err = -ENOMEM;



    \
     
     \ /
      Last update: 2011-04-13 18:23    [W:0.021 / U:0.420 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site