Messages in this thread Patch in this message | | | Date | Wed, 13 Apr 2011 09:09:29 -0700 | From | Greg KH <> | Subject | [06/71] cciss: fix lost command issue |
| |
2.6.33-longterm review patch. If anyone has any objections, please let us know.
------------------
From: Bud Brown <bud.brown@redhat.com>
commit 1ddd5049545e0aa1a0ed19bca4d9c9c3ce1ac8a2 upstream.
Under certain workloads a command may seem to get lost. IOW, the Smart Array thinks all commands have been completed but we still have commands in our completion queue. This may lead to system instability, filesystems going read-only, or even panics depending on the affected filesystem. We add an extra read to force the write to complete.
Testing shows this extra read avoids the problem.
Signed-off-by: Mike Miller <mike.miller@hp.com> Signed-off-by: Jens Axboe <jaxboe@fusionio.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- drivers/block/cciss.h | 1 + 1 file changed, 1 insertion(+)
--- a/drivers/block/cciss.h +++ b/drivers/block/cciss.h @@ -181,6 +181,7 @@ static void SA5_submit_command( ctlr_inf printk("Sending %x - down to controller\n", c->busaddr ); #endif /* CCISS_DEBUG */ writel(c->busaddr, h->vaddr + SA5_REQUEST_PORT_OFFSET); + readl(h->vaddr + SA5_REQUEST_PORT_OFFSET); h->commands_outstanding++; if ( h->commands_outstanding > h->max_outstanding) h->max_outstanding = h->commands_outstanding;
| |