Messages in this thread | | | Date | Tue, 12 Apr 2011 21:53:21 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 2/6] signal: retarget_shared_pending: consider shared/unblocked signals only |
| |
On 04/12, Matt Fleming wrote: > > On Mon, 11 Apr 2011 19:20:45 +0200 > Oleg Nesterov <oleg@redhat.com> wrote: > > > exit_signals() checks signal_pending() before > > retarget_shared_pending() but this is suboptimal. We can avoid the > > while_each_thread() loop in case when there are no shared signals > > visible to us. > > > > Add the has_pending_signals(shared_pending, blocked) check. We don > > not use tsk->blocked directly but pass this sigset_t as an argument, > > this is needed for the next patch. > > > > Note: we can optimize this more. while_each_thread(t) can check > > t->blocked into account and stop after every pending signal has the > > new target. > > > > Signed-off-by: Oleg Nesterov <oleg@redhat.com> > > Nice. Do you have plans to implement that further optimisation?
Probably yes, this is straightforward...
> Reviewed-by: Matt Fleming <matt.fleming@linux.intel.com>
Thanks Matt, thanks all.
I'll reply to other emails tomorrow. I was distracted by other things, sorry. Oh, as always :/
Oleg.
| |