lkml.org 
[lkml]   [2011]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[078/105] char/tpm: Fix unitialized usage of data buffer
    2.6.38-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Peter Huewe <huewe.external.infineon@googlemail.com>

    commit 1309d7afbed112f0e8e90be9af975550caa0076b upstream.

    This patch fixes information leakage to the userspace by initializing
    the data buffer to zero.

    Reported-by: Peter Huewe <huewe.external@infineon.com>
    Signed-off-by: Peter Huewe <huewe.external@infineon.com>
    Signed-off-by: Marcel Selhorst <m.selhorst@sirrix.com>
    [ Also removed the silly "* sizeof(u8)". If that isn't 1, we have way
    deeper problems than a simple multiplication can fix. - Linus ]
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/char/tpm/tpm.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/char/tpm/tpm.c
    +++ b/drivers/char/tpm/tpm.c
    @@ -980,7 +980,7 @@ int tpm_open(struct inode *inode, struct
    return -EBUSY;
    }

    - chip->data_buffer = kmalloc(TPM_BUFSIZE * sizeof(u8), GFP_KERNEL);
    + chip->data_buffer = kzalloc(TPM_BUFSIZE, GFP_KERNEL);
    if (chip->data_buffer == NULL) {
    clear_bit(0, &chip->is_open);
    put_device(chip->dev);



    \
     
     \ /
      Last update: 2011-04-12 17:05    [W:0.021 / U:30.220 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site