Messages in this thread | | | Date | Mon, 11 Apr 2011 13:46:01 -0500 | From | Larry Finger <> | Subject | Re: [rt2x00-users] [PATCH] rt2800pci: rt2800usb: Firmware update |
| |
On 04/11/2011 01:25 PM, Gertjan van Wingerde wrote: > On 04/11/11 20:13, Ben Hutchings wrote: >> On Mon, Apr 11, 2011 at 07:57:15PM +0200, Ivo Van Doorn wrote: >>>>> From: Shiang Tu<shiang_tu@ralinktech.com> >>>>> >>>>> Update firmware for rt2800pci to Version 34 and firmware for rt2800usb to >>>>> Version 29. >>>>> >>>>> Signed-off-by: Shiang Tu<shiang_tu@ralinktech.com> >>>>> Signed-off-by: Larry Finger<Larry.Finger@lwfinger.net> >>>>> --- >>>>> WHENCE | 8 ++++---- >>>>> rt2860.bin | Bin 8192 -> 8192 bytes >>>>> rt2870.bin | Bin 4096 -> 8192 bytes >>>>> 3 files changed, 4 insertions(+), 4 deletions(-) >>>> >>>> links to rt3070.bin rt3071.bin rt3090.bin ??? >>> >>> What do you mean? Those files should be deleted from the linux-firmware >>> package. There is no need to keep them around, as with the removal of >>> the staging drivers, the last users of those files are gone. >> >> Stop repeating this nonsense, Ivo. If the firmware has been bundled in >> the Linux tree, that would be correct. For linux-firmware the policy is >> different. > > It's unbelievable how much fuzz a set of binary firmware files can create. > > To be honest, I do not care whether they stay or go, as long as it is very > clear that rt2x00 does not need, and will never need those files. If they > stay, I would recommend simply not touching them at all, and leave them as > they are, so that nothing changes for the people running the staging driver > (at least with respect to these 3 firmware files). > > Larry, it might be best to update your changes to the WHENCE file to clearly > state that these 3 files are only needed for the staging rt2860sta driver, > up to kernel 2.6.39 (assuming that that staging driver will be removed in 2.6.40).
Agreed. I'll add that as soon as I get the requested info about what changed from Ralink.
I can test if linking rt3090.bin to rt2860.bin works for the PCI device, but I have no USB stick for testing. As a result, I'm inclined to leave those files intact for the foreseeable future.
Off-Topic: What are some makes/models of USB sticks? If there are some inexpensive models on E-bay, I could add to my collection.
Larry
| |