lkml.org 
[lkml]   [2011]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [RFC] block integrity: Fix write after checksum calculation problem
    Date
    Excerpts from Christoph Hellwig's message of 2011-04-11 14:25:41 -0400:
    > On Mon, Apr 11, 2011 at 01:41:16PM -0400, Chris Mason wrote:
    > > Actually this isn't a nit. Keeping the page locked closes an important
    > > hole where it can become writeback again. It might fix the last
    > > remaining problem.
    >
    > Note that the generic block_page_mkwrite atually does that. But only
    > xfs and nilfs2 actually make use of it.
    >

    Btrfs does return VM_FAULT_LOCKED though. I had forgotten to look for
    this in the ext4 page_mkwrite call.

    -chris


    \
     
     \ /
      Last update: 2011-04-11 20:43    [W:0.019 / U:237.952 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site