lkml.org 
[lkml]   [2011]   [Apr]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: 2.6.39-rc2 regression: X201s fails to resume b77dcf8460ae57d4eb9fd3633eb4f97b8fb20716
    From
    Hi Gustavo,

    On Mon, Apr 11, 2011 at 1:34 PM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
    >> I took a shot at it and just sent a patch (also attached for convenience)
    >> that should solve the problem.
    >
    > Well its reverting too much but its also looking pretty bogus to me
    >
    > -       /* Stop timer, it might be running */
    > -       del_timer_sync(&hdev->cmd_timer);
    > -
    >        if (!test_and_clear_bit(HCI_UP, &hdev->flags)) {
    >                hci_req_unlock(hdev);
    >                return 0;
    >
    > So you've now got a path where you leave the timer running and didn't
    > before - not it appears one that is a good idea.
    >
    > Certainly not the kind of change that should be considered for a
    > regression fix for an rc kernel. It's far too big a behavioural change to
    > be safe.

    Considering what was said and that this patch didn't hit your public tree yet,
    I guess that this patch should be ignored.

    Will send a proper fix soon. Thanks all.

    >
    > Alan
    >


    Cheers,
    --
    Vinicius
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-04-11 19:01    [W:0.024 / U:31.164 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site