Messages in this thread | | | Date | Mon, 11 Apr 2011 17:34:09 +0100 | From | Alan Cox <> | Subject | Re: 2.6.39-rc2 regression: X201s fails to resume b77dcf8460ae57d4eb9fd3633eb4f97b8fb20716 |
| |
> I took a shot at it and just sent a patch (also attached for convenience) > that should solve the problem.
Well its reverting too much but its also looking pretty bogus to me
- /* Stop timer, it might be running */ - del_timer_sync(&hdev->cmd_timer); - if (!test_and_clear_bit(HCI_UP, &hdev->flags)) { hci_req_unlock(hdev); return 0;
So you've now got a path where you leave the timer running and didn't before - not it appears one that is a good idea.
Certainly not the kind of change that should be considered for a regression fix for an rc kernel. It's far too big a behavioural change to be safe.
Alan
| |