[lkml]   [2011]   [Apr]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] x86 idle APM: delete apm_cpu_idle(), and its use of pm_idle
On Wed, 30 Mar 2011, Len Brown wrote:

> From: Len Brown <>
> There is some doubt whether the APM idle feature
> to call into the BIOS from the idle loop is reliable.
> Certainly it was known to fail on some machines,
> but more importantly, APM machines have not shipped
> for a decade and so finding machines to test the code
> is problematic.
> After this patch, systems running in APM mode will
> simply run default_idle() and HALT without calling
> into the BIOS from their idle loop.
> This deletes a much-maligned modular user of the (pm_idle)()
> function pointer.
> Signed-off-by: Len Brown <>
> ---
> Jiri,
> If you can review, test, ack, that would be great.
> I'll probably end up shipping this via the idle tree
> because subsequent patches to delete pm_idle
> will depend on it.

Looks fine, works here.

Acked-by: Jiri Kosina <>

Thanks Len.

Jiri Kosina
SUSE Labs, Novell Inc.

 \ /
  Last update: 2011-04-01 11:31    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean