Messages in this thread | | | From | "Henrik Rydberg" <> | Date | Wed, 9 Mar 2011 10:47:48 +0100 | Subject | Re: [PATCH 3/4] hid-multitouch: migrate 3M PCT touch screens to the unified driver. |
| |
On Wed, Mar 09, 2011 at 10:13:55AM +0100, Benjamin Tissoires wrote: > Hi Henrik > > On Wed, Mar 9, 2011 at 09:46, Henrik Rydberg <rydberg@euromail.se> wrote: > > Hi Benjamin, > > > > On Tue, Mar 08, 2011 at 05:32:58PM +0100, Benjamin Tissoires wrote: > >> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@enac.fr> > >> --- > > > > Semms this patch is missing a commit message. > > You can copy/paste this point to the other patches as well. > > How about: > "3M PCT touch screens can be handled by the unified driver. This will > ease future evolution. So, just move it." > > Then I'll copy/paste for the others.
I bet every driver merge has its own considerations that deserve comment. A good commit message gives an introduction to the code change and gives some context to the reader. Richard made a nice one for the egalax driver.
Henrik
| |