lkml.org 
[lkml]   [2011]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] power: bq20z75: Fix time and temp units
From
Date
On Sun, 2011-02-27 at 17:41 -0800, Benson Leung wrote:
> Corrected temperature and time to empty/full conversions.
> Temperature is in 0.1°C, time is in seconds.
>
> Corrected units in comment. "Convert to µWh."
>
> Signed-off-by: Benson Leung <bleung@chromium.org>
> ---
> drivers/power/bq20z75.c | 18 ++++++++++++------
> 1 files changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/power/bq20z75.c b/drivers/power/bq20z75.c
> index 4141775..123e169 100644
> --- a/drivers/power/bq20z75.c
> +++ b/drivers/power/bq20z75.c
> @@ -269,12 +269,15 @@ static void bq20z75_unit_adjustment(struct i2c_client *client,
> {
> #define BASE_UNIT_CONVERSION 1000
> #define BATTERY_MODE_CAP_MULT_WATT (10 * BASE_UNIT_CONVERSION)
> -#define TIME_UNIT_CONVERSION 600
> -#define TEMP_KELVIN_TO_CELCIUS 2731
> +#define TIME_UNIT_CONVERSION 60
> +#define TEMP_KELVIN_TO_CELSIUS 2731
> switch (psp) {
> case POWER_SUPPLY_PROP_ENERGY_NOW:
> case POWER_SUPPLY_PROP_ENERGY_FULL:
> case POWER_SUPPLY_PROP_ENERGY_FULL_DESIGN:
> + /* bq20z75 provides energy in units of 10mWh.
> + * Convert to µWh
> + */
> val->intval *= BATTERY_MODE_CAP_MULT_WATT;
> break;
>
> @@ -288,14 +291,17 @@ static void bq20z75_unit_adjustment(struct i2c_client *client,
> break;
>
> case POWER_SUPPLY_PROP_TEMP:
> - /* bq20z75 provides battery tempreture in 0.1°K
> - * so convert it to 0.1°C */
> - val->intval -= TEMP_KELVIN_TO_CELCIUS;
> - val->intval *= 10;
> + /* bq20z75 provides battery temperature in 0.1K
> + * so convert it to 0.1°C
> + */
> + val->intval -= TEMP_KELVIN_TO_CELSIUS;
> break;
>
> case POWER_SUPPLY_PROP_TIME_TO_EMPTY_AVG:
> case POWER_SUPPLY_PROP_TIME_TO_FULL_AVG:
> + /* bq20z75 provides time to empty and time to full in minutes.
> + * Convert to seconds
> + */
> val->intval *= TIME_UNIT_CONVERSION;
> break;
>

LGTM

Acked-by: Rhyland Klein <rklein@nvidia.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-03-09 20:03    [W:0.062 / U:2.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site