lkml.org 
[lkml]   [2011]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PWM v6 1/3] PWM: Implement a generic PWM framework
From
On Sun, Mar 6, 2011 at 12:16 AM, Lars-Peter Clausen <lars@metafoo.de> wrote:

>
>> +     if (IS_ERR(p->dev)) {
>> +             ret = PTR_ERR(p->dev);
>> +             goto err_device_create;
>> +     }
> I think it would be better to embedd the device struct directly into the
> pwm_device struct. You could also remove the data field of the pwm_device
> struct and use dev_{get,set}_drvdata for pwm_{get,set}_drvdata.

In theory I agree with you, but it would take away my ability to do
things like device_create_vargs() and thereby make my code a bit more
complicated and error prone. Do you think the advantages outweigh the
disadvantages?


b.g.
--
Bill Gatliff
bgat@billgatliff.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-03-09 18:07    [from the cache]
©2003-2011 Jasper Spaans