Messages in this thread | | | Date | Wed, 9 Mar 2011 15:16:07 +0000 | Subject | Re: [RFC][PATCH 4/6] arm, mm: Convert arm to generic tlb | From | Catalin Marinas <> |
| |
Hi Peter,
On 2 March 2011 17:59, Peter Zijlstra <a.p.zijlstra@chello.nl> wrote: > --- linux-2.6.orig/arch/arm/include/asm/tlb.h > +++ linux-2.6/arch/arm/include/asm/tlb.h [...] > +__pte_free_tlb(struct mmu_gather *tlb, pgtable_t pte, unsigned long addr) > { > pgtable_page_dtor(pte); > - tlb_add_flush(tlb, addr); > tlb_remove_page(tlb, pte); > }
I think we still need a tlb_track_range() call here. On the path to pte_free_tlb() (for example shift_arg_pages ... free_pte_range) there doesn't seem to be any code setting the tlb->start/end range. Did I miss anything?
Thanks.
-- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |