lkml.org 
[lkml]   [2011]   [Mar]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] perf,top: fix events overflow in top command
Em Mon, Mar 07, 2011 at 09:13:40PM +0100, Jiri Olsa escreveu:
> The snprintf function returns number of printed characters even
> if it cross the size parameter. So passing enough events via '-e'
> parameter will cause segmentation fault.
>
> It's reproduced by following command:
>
> perf top -e `perf list | grep Tracepoint | awk -F'[' '\
> {gsub(/[[:space:]]+/,"",$1);array[FNR]=$1}END{outputs=array[1];\
> for (i=2;i<=FNR;i++){ outputs=outputs "," array[i];};print outputs}'`
>
> Attached patch is adding SNPRINTF macro that provides the
> overflow check and returns actuall number of printed characters.

Good catch, applying to perf/urgent.

- Arnaldo


\
 
 \ /
  Last update: 2011-03-09 15:01    [W:0.101 / U:0.508 seconds]
©2003-2014 Jasper Spaans. Advertise on this site