lkml.org 
[lkml]   [2011]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH next 1/5] staging: bcm: optimize kmalloc to kzalloc
    Date
    Use kzalloc rather than kmalloc followed by memset with 0.
    Found by coccinelle.

    Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
    ---
    drivers/staging/bcm/Bcmchar.c | 4 +---
    drivers/staging/bcm/Misc.c | 6 ++----
    2 files changed, 3 insertions(+), 7 deletions(-)

    diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
    index 3d9055a..867dbf1 100644
    --- a/drivers/staging/bcm/Bcmchar.c
    +++ b/drivers/staging/bcm/Bcmchar.c
    @@ -19,12 +19,10 @@ static int bcm_char_open(struct inode *inode, struct file * filp)
    PPER_TARANG_DATA pTarang = NULL;

    Adapter = GET_BCM_ADAPTER(gblpnetdev);
    - pTarang = (PPER_TARANG_DATA)kmalloc(sizeof(PER_TARANG_DATA),
    - GFP_KERNEL);
    + pTarang = kzalloc(sizeof(PER_TARANG_DATA), GFP_KERNEL);
    if (!pTarang)
    return -ENOMEM;

    - memset(pTarang, 0, sizeof(PER_TARANG_DATA));
    pTarang->Adapter = Adapter;
    pTarang->RxCntrlMsgBitMask = 0xFFFFFFFF & ~(1 << 0xB);

    diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/bcm/Misc.c
    index f585aae..d624f35 100644
    --- a/drivers/staging/bcm/Misc.c
    +++ b/drivers/staging/bcm/Misc.c
    @@ -498,13 +498,12 @@ VOID LinkMessage(PMINI_ADAPTER Adapter)
    BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, LINK_UP_MSG, DBG_LVL_ALL, "=====>");
    if(Adapter->LinkStatus == SYNC_UP_REQUEST && Adapter->AutoSyncup)
    {
    - pstLinkRequest=kmalloc(sizeof(LINK_REQUEST), GFP_ATOMIC);
    + pstLinkRequest = kzalloc(sizeof(LINK_REQUEST), GFP_ATOMIC);
    if(!pstLinkRequest)
    {
    BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, LINK_UP_MSG, DBG_LVL_ALL, "Can not allocate memory for Link request!");
    return;
    }
    - memset(pstLinkRequest,0,sizeof(LINK_REQUEST));
    //sync up request...
    Adapter->LinkStatus = WAIT_FOR_SYNC;// current link status
    BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, LINK_UP_MSG, DBG_LVL_ALL, "Requesting For SyncUp...");
    @@ -516,13 +515,12 @@ VOID LinkMessage(PMINI_ADAPTER Adapter)
    }
    else if(Adapter->LinkStatus == PHY_SYNC_ACHIVED && Adapter->AutoLinkUp)
    {
    - pstLinkRequest=kmalloc(sizeof(LINK_REQUEST), GFP_ATOMIC);
    + pstLinkRequest = kzalloc(sizeof(LINK_REQUEST), GFP_ATOMIC);
    if(!pstLinkRequest)
    {
    BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, LINK_UP_MSG, DBG_LVL_ALL, "Can not allocate memory for Link request!");
    return;
    }
    - memset(pstLinkRequest,0,sizeof(LINK_REQUEST));
    //LINK_UP_REQUEST
    BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, LINK_UP_MSG, DBG_LVL_ALL, "Requesting For LinkUp...");
    pstLinkRequest->szData[0]=LINK_UP_REQ_PAYLOAD;
    --
    1.7.4.1


    \
     
     \ /
      Last update: 2011-03-09 01:57    [W:0.047 / U:120.712 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site