lkml.org 
[lkml]   [2011]   [Mar]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    SubjectRe: linux-next: Tree for March 8 (BROKEN: arch/x86/kernel/entry_32.S? Debian's binutils/as?)
    From
    On 3/8/11, Sedat Dilek <sedat.dilek@googlemail.com> wrote:
    > On 3/8/11, H.J. Lu <hjl.tools@gmail.com> wrote:
    >> On Tue, Mar 8, 2011 at 2:44 AM, Sedat Dilek <sedat.dilek@googlemail.com>
    >> wrote:
    >>> Hi,
    >>>
    >>> my build of linux-next (next-20110308, the same with the one from
    >>> yesterday) is broken.
    >>> (I translated the German output.)
    >>>
    >>> [ build.log ]
    >>> AS arch/x86/kernel/entry_32.o
    >>> /home/sd/src/linux-2.6/linux-2.6.38-rc7/debian/build/source_i386_none/arch/x86/kernel/entry_32.S:
    >>> Assembler messages:
    >>> /home/sd/src/linux-2.6/linux-2.6.38-rc7/debian/build/source_i386_none/arch/x86/kernel/entry_32.S:1421:
    >>> Error: .size expression does not evaluate to a constant
    >>> make[6]: *** [arch/x86/kernel/entry_32.o] Fehler 1 (Error 1)
    >>> make[5]: *** [arch/x86/kernel] Fehler 2 (Error 2)
    >>> make[4]: *** [arch/x86] Fehler 2 (Error 2)
    >>> make[4]: *** Warte auf noch nicht beendete Prozesse... (Waiting for
    >>> unfinished jobs...)
    >>>
    >>
    >> This is a kernel bug. Please use the latest binutils from CVS.
    >> It will tell you which symbol causes this.
    >>
    >>
    >> --
    >> H.J.
    >>
    >
    > Yeah, I have cherry-picked these two upstream commits before you have
    > mentionned it...
    >
    > 0001-Mention-symbol-name-in-non-constant-.size-expression.patch
    > (Cherry-picked from commit b9521fc0be7945fc842ce1197e241a023378125d)
    > 0002-Revert-the-last-change-on-gas-elf-bad-size.err.patch
    > (Cherry-picked from commit cbd141bb69f791de7ea1581abe7afb34f0c61288)
    >
    > ... and have built with them a new binutils Debian package.
    >
    > The error looks now like this (sorry for the German output):
    > ...
    > AS arch/x86/kernel/entry_32.o
    > /home/sd/src/linux-2.6/linux-2.6.38-rc7/debian/build/source_i386_none/arch/x86/kernel/entry_32.S:
    > Assembler messages:
    > /home/sd/src/linux-2.6/linux-2.6.38-rc7/debian/build/source_i386_none/arch/x86/kernel/entry_32.S:1421:
    > Error: .size expression with symbol `apf_page_fault' does not evaluate
    > to a constant
    > make[6]: *** [arch/x86/kernel/entry_32.o] Fehler 1
    > make[5]: *** [arch/x86/kernel] Fehler 2
    > make[5]: *** Warte auf noch nicht beendete Prozesse...
    >
    > Anyway, before more riddling around it would be very helpful to have a
    > clear pointer if there is a fix around... That building, testing and
    > installing took me now several hours.
    > And... yeah, backports to 2.21-branch appreciated.
    >
    > - Sedat -
    >

    After a quick look into the source, it seems attached patch fixes the issue.
    Is that OK?

    - Sedat -
    From c4f8070805fff7c0d097b7a0fb4f549ebd14a74b Mon Sep 17 00:00:00 2001
    From: Sedat Dilek <sedat.dilek@gmail.com>
    Date: Tue, 8 Mar 2011 16:32:18 +0100
    Subject: [PATCH] x86: Fix build failure with binutils/as from upstream

    This is from my build log:
    [...]
    AS arch/x86/kernel/entry_32.o
    arch/x86/kernel/entry_32.S: Assembler messages:
    arch/x86/kernel/entry_32.S:1421: Error: .size expression with symbol `apf_page_fault' does not evaluate to a constant

    Signed-off-by: Sedat Dilek <sedat.dilek@gmail.com>
    ---
    arch/x86/kernel/entry_32.S | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/arch/x86/kernel/entry_32.S b/arch/x86/kernel/entry_32.S
    index c8b4efa..9ca3b0e 100644
    --- a/arch/x86/kernel/entry_32.S
    +++ b/arch/x86/kernel/entry_32.S
    @@ -1413,7 +1413,7 @@ ENTRY(async_page_fault)
    CFI_ADJUST_CFA_OFFSET 4
    jmp error_code
    CFI_ENDPROC
    -END(apf_page_fault)
    +END(async_page_fault)
    #endif

    /*
    --
    1.7.4.1
    \
     
     \ /
      Last update: 2011-03-08 16:45    [W:0.027 / U:91.716 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site