[lkml]   [2011]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 11/21] staging: ft1000: Fix coding style in ft1000_usb_transmit_complete function.
    On Mon, Mar 07, 2011 at 08:25:07PM +0100, Belisko Marek wrote:
    > On Mon, Mar 7, 2011 at 4:55 PM, Dan Carpenter <> wrote:
    > > On Mon, Mar 07, 2011 at 09:21:16AM +0100, Marek Belisko wrote:
    > >> -    if (urb->status)
    > >> -        printk("%s: TX status %d\n", ft1000dev->net->name, urb->status);
    > >> +     if (urb->status)
    > >> +             DEBUG("%s: TX status %d\n", ft1000dev->net->name, urb->status);
    > >>
    > >
    > > Why did you change the printk() to a DEBUG()?  That's a behavior change,
    > > and it should have been mentioned in the commit message.
    > Mea culpa. complain about no KERN_... prefix so just fix with
    > replace to DEBUG. Will return back to printk.
    > @Greg: should resend whole serie or just this patch?

    pr_err() or pr_info() would probably be better.

    Here is how the usb-skeleton driver handles this btw:

    /* sync/async unlink faults aren't errors */
    if (urb->status) {
    if (!(urb->status == -ENOENT ||
    urb->status == -ECONNRESET ||
    urb->status == -ESHUTDOWN))
    err("%s - nonzero write bulk status received: %d",
    __func__, urb->status);

    dev->errors = urb->status;
    } else {
    dev->bulk_in_filled = urb->actual_length;

    That uses the old usb err() macro which I think is not recomended these
    days. Use pr_err() instead.

    Do the other patches still apply if you resend just this patch? Btw
    git send-email has a --in-reply-to option so that the V2 is attached to
    the same thread as the original patch.

    dan carpenter

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2011-03-07 21:41    [W:0.023 / U:152.800 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site